Skip to content

feat(env): add .env scaffolding and profile preset support#23

Merged
wax911 merged 1 commit into
mainfrom
feat/14-env-scaffolding
Jul 3, 2026
Merged

feat(env): add .env scaffolding and profile preset support#23
wax911 merged 1 commit into
mainfrom
feat/14-env-scaffolding

Conversation

@wax911

@wax911 wax911 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Closes #14

  • Discovers .env.example files across the repo
  • Lists missing .env files (diff mode)
  • Recreates .env from .env.example without overwriting (or --force)
  • Non-secret env scaffolding only

@wax911 wax911 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review notes against #14:

The PR body only claims discovery, listing missing files, recreate, force behavior, and non-secret scaffolding. The issue had several additional acceptance paths that need to be either implemented or explicitly deferred:

  1. --paths filtering for explicit service directories/files.
  2. --profile dev --materialize / --from-profile dev behavior.
  3. env doctor with sensitive plaintext warnings.
  4. Status listing that distinguishes example files, active plaintext env files, encrypted env files, and profile variants.
  5. Backup behavior before forced overwrite.
  6. Dry-run coverage for every mutating path.

Please update the PR body and tests to prove these are covered, or narrow the issue/PR scope so it does not close #14 prematurely.

@wax911 wax911 marked this pull request as draft June 29, 2026 15:44

@wax911 wax911 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review after the push:

This PR is now draft, which is appropriate, but it is still not ready:

  1. It still targets main and carries a cumulative diff. Retarget it to the correct predecessor branch once the stack order is settled.

  2. The PR body still only claims the smaller env subset and does not mention the previously missing acceptance paths: --paths, profile materialization, env doctor, sensitive plaintext warnings, forced-overwrite backups, and dry-run coverage.

  3. Because the body still says Closes #14, it currently overclaims completion unless those missing paths are implemented and tested.

Either broaden the implementation to fully close #14 or narrow the PR and split the remaining env requirements into follow-up issues.

@wax911 wax911 force-pushed the feat/14-env-scaffolding branch from 8553740 to 6633033 Compare July 3, 2026 07:13
@wax911 wax911 marked this pull request as ready for review July 3, 2026 07:14
@wax911 wax911 merged commit fa99759 into main Jul 3, 2026
1 check passed
@wax911 wax911 deleted the feat/14-env-scaffolding branch July 3, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(env): add .env scaffolding and profile preset support

1 participant